Skip PostgreSQL checklist tests when the test database is not configured #69

New Issue

2026-11-05T12:09:31Z

spencerm commented

2026-11-05 12:09:31 +00:00

Priority: low.

The four tests in tests/server/test_c8_checklists.py:45 use pg_settings without the database-availability skip guard used elsewhere. tests/server/conftest.py:33 asserts PG_URL and raises during setup when TEST_PG_SUPERUSER_URL is unset.

Reproduced locally: 5,554 passed, 604 skipped and four setup errors. Affected tests: test_list_and_get, test_who_may_save, test_version_cas_and_validation, test_a_change_reaches_only_stages_not_started.

Acceptance criteria:

Add the established needs_pg marker or skip centrally in the fixture when the URL is absent.
A local suite without PostgreSQL should skip these tests rather than error.
Configured CI must still execute them normally and surface actual database failures.

Source: parent and GLM; confirmed by local pytest execution.

Reviewed revision: 18333600b55b70971877c1a0c72d1d61b6ce9c69. Raised from the November 2026 independent project reviews and parent verification. No production system was tested.

Priority: low. The four tests in [tests/server/test_c8_checklists.py:45](https://gt.pescoinc.biz/spencerm/PacketStation/src/commit/18333600b55b70971877c1a0c72d1d61b6ce9c69/tests/server/test_c8_checklists.py#L45) use pg_settings without the database-availability skip guard used elsewhere. [tests/server/conftest.py:33](https://gt.pescoinc.biz/spencerm/PacketStation/src/commit/18333600b55b70971877c1a0c72d1d61b6ce9c69/tests/server/conftest.py#L33) asserts PG_URL and raises during setup when TEST_PG_SUPERUSER_URL is unset. Reproduced locally: 5,554 passed, 604 skipped and four setup errors. Affected tests: test_list_and_get, test_who_may_save, test_version_cas_and_validation, test_a_change_reaches_only_stages_not_started. Acceptance criteria: - Add the established needs_pg marker or skip centrally in the fixture when the URL is absent. - A local suite without PostgreSQL should skip these tests rather than error. - Configured CI must still execute them normally and surface actual database failures. Source: parent and GLM; confirmed by local pytest execution. Reviewed revision: `18333600b55b70971877c1a0c72d1d61b6ce9c69`. Raised from the November 2026 independent project reviews and parent verification. No production system was tested.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: spencerm/PacketStation#69